Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting workflow from rocm-docs-core #143

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Conversation

samjwu
Copy link
Member

@samjwu samjwu commented Oct 26, 2023

@samjwu samjwu added documentation Improvements or additions to documentation ci:docs-only Skip most non-doc CI checks for this PR labels Oct 26, 2023
@samjwu samjwu requested a review from saadrahim October 26, 2023 22:28
@samjwu samjwu self-assigned this Oct 26, 2023
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samjwu
Is this needed for ROCm 6.0 as well?
Who shall address the linting failures reported?

@samjwu
Copy link
Member Author

samjwu commented Nov 2, 2023

I have made changes to get Markdown lint passing
ROCm/rocm-docs-core#488 should fix the spell check

@cgmillette cgmillette merged commit 78a38e9 into ROCm:develop Nov 3, 2023
5 of 6 checks passed
@samjwu samjwu deleted the doclint branch November 3, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs-only Skip most non-doc CI checks for this PR documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants